@dzenanz @tbirdso @thewtex Do you have any clue about the CI build failures? Other pull requests (for example #230) seem to have the same build failures, specifically on cxx-build-workflow / build-test-cxx (windows-2022)

Maybe the same thing as fixed here and here?

Did SetInitialTransform work before this PR?

@tao558 If SetInitialTransform did not work before this PR, it might explain why some of the things I tried in registration notebook didn't work.

Did SetInitialTransform work before this PR?

No, this PR adds ElastixRegistrationMethod.SetInitialTransform to ITKElastix for the first time. Although there were similar member functions already: SetInitialTransformParameterFileName, and SetInitialTransformParameterObject. The newly added member function allows passing an ITK transform object directly as argument.

Maybe the same thing as fixed here and here?

Interesting... Do you mean ITKElastix should upgrade to a newer revision of ITKRemoteModuleBuildTestPackageAction?

Looking at

Do you mean ITKElastix should upgrade to a newer revision of ITKRemoteModuleBuildTestPackageAction

I agree with @dzenanz , please first update to the latest commit in ITKRemoteModuleBuildTestPackageAction.

"cxx-build-workflow / build-test-cxx (windows-2022)" builds fine now that pull request #235 commit 7bdc103 is merged 👍

However, python-build-workflow-dev / build-linux-py (7, 2014-x64) still fails, saying:

ERROR    InvalidDistribution: Cannot find file (or expand pattern):             
         'dist/itk_*cp37*manylinux2014*x86_64.whl' 

Any suggestion?

Looks like python-build-workflow-dev / build-macos-py (11) is still using C++14, while elastix really needs C++17 now.

cd /Users/runner/work/ITKElastix/ITKElastix/_skbuild/macosx-10.9-universal2-3.11/cmake-build/Wrapping/Modules/Elastix && env SDKROOT=/Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.1.sdk MACOSX_DEPLOYMENT_TARGET=10.9 /Users/runner/work/ITKElastix/ITKElastix/_skbuild/macosx-10.9-universal2-3.11/cmake-build/Wrapping/Generators/CastXML/castxml/bin/castxml -o /Users/svc-dashboard/D/P/ITKPythonPackage/scripts/../ITK-3.11-macosx_x86_64/Wrapping/castxml_inputs/itkElastixRegistrationMethod.xml --castxml-gccxml --castxml-start _wrapping_ --castxml-cc-gnu "(" /Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -std=c++14 ")" -w -c @/Users/svc-dashboard/D/P/ITKPythonPackage/scripts/../ITK-3.11-macosx_x86_64/Wrapping/castxml_inputs/.castxml.inc /Users/svc-dashboard/D/P/ITKPythonPackage/scripts/../ITK-3.11-macosx_x86_64/Wrapping/castxml_inputs/itkElastixRegistrationMethod.cxx
In file included from /Users/svc-dashboard/D/P/ITKPythonPackage/scripts/../ITK-3.11-macosx_x86_64/Wrapping/castxml_inputs/itkElastixRegistrationMethod.cxx:16:
In file included from /Users/runner/work/ITKElastix/ITKElastix/_skbuild/macosx-10.9-universal2-3.11/cmake-build/_deps/elx-src/Core/Main/itkElastixRegistrationMethod.h:41:
In file included from /Users/runner/work/ITKElastix/ITKElastix/_skbuild/macosx-10.9-universal2-3.11/cmake-build/_deps/elx-src/Core/Kernel/elxElastixMain.h:21:
In file included from /Users/runner/work/ITKElastix/ITKElastix/_skbuild/macosx-10.9-universal2-3.11/cmake-build/_deps/elx-src/Core/Kernel/elxMainBase.h:23:
In file included from /Users/runner/work/ITKElastix/ITKElastix/_skbuild/macosx-10.9-universal2-3.11/cmake-build/_deps/elx-src/Core/Kernel/elxElastixBase.h:33:
In file included from /Users/runner/work/ITKElastix/ITKElastix/_skbuild/macosx-10.9-universal2-3.11/cmake-build/_deps/elx-src/Core/Configuration/elxConfiguration.h:25:
In file included from /Users/runner/work/ITKElastix/ITKElastix/_skbuild/macosx-10.9-universal2-3.11/cmake-build/_deps/elx-src/Common/ParameterFileParser/itkParameterMapInterface.h:22:
/Users/runner/work/ITKElastix/ITKElastix/_skbuild/macosx-10.9-universal2-3.11/cmake-build/_deps/elx-src/Core/Install/elxConversion.h:92:24: error: no template named 'is_integral_v' in namespace 'std'; did you mean 'is_integral'?

Specifically, 'is_integral_v' is introduced with C++17, while this particular compiler says:

error: no template named 'is_integral_v' in namespace 'std'; did you mean 'is_integral'?

The compiler appears to be run as usr/bin/c++ -std=c++14, according to the output above here, while that should be -std=c++14!

Any suggestion where this should be specified?

Update: I see now, it also says:

2023-07-21T12:43:33.9935110Z FAILED: /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-3.11-macosx_x86_64/Wrapping/castxml_inputs/itkElastixRegistrationMethod.xml
...
2023-07-21T12:43:35.8310640Z FAILED: /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-3.11-macosx_x86_64/Wrapping/castxml_inputs/itkTransformixFilter.xml

Looks like python-build-workflow-dev / build-macos-py (11) is still using C++14, while elastix really needs C++17 now.

@N-Dekker Thanks for finding this. As ITK requires a minimum of C++17 it is reasonable to require external modules to do the same. This seems like a bug in build-macos-py. Logged here: InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#66

@N-Dekker thanks for working on the initial transform support 👏

@N-Dekker This should be fixed by the itk-5.4rc01 builds, where C++17 is enabled by the default via ITK. It could be tested by setting versions as in this PR: InsightSoftwareConsortium/ITKSplitComponents#72.

Thanks to you both @tbirdso and @thewtex So I guess ITKElastix should upgrade both ITKRemoteModuleBuildTestPackageAction (to include a fix for InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#66 ) and ITK (to itk-5.4rc01 at least), before upgrading to the latest (C++17 based) SuperElastix/elastix, right?

So I guess ITKElastix should upgrade both ITKRemoteModuleBuildTestPackageAction and ITK before upgrading to the latest (C++17 based) SuperElastix/elastix, right?

Yes, I agree. Here is a potential roadmap for upgrading ITKElastix to the latest Elastix build with C++17:

1. Merge Itk 5.3rc01 ITKRemoteModuleBuildTestPackageAction#67 into ITKRemoteModuleBuildTestPackageAction@v5.4.0 feature branch once tests pass (DONE)
2. Update ITKElastix CI to point to ITKRemoteModuleBuildTestPackageAction@v5.4.0 feature branch (or fixed commit hash at HEAD). This will include C++17 tooling and an updated ref to ITK v5.4rc01. (See ENH: Bump for ITK v5.4rc01 #236) (DONE)
3. Update ITKElastix to the latest Elastix build (here)

EDIT: Updated roadmap with progress.

@N-Dekker FYI, ITKElastix is now updated to target ITK v5.4rc1 with C++17 build tools. Please rebase this PR on main.

Thanks for your approval Tom! For the sake of time, I'll just merge now!